peter
e887233210
A refused Facebook cookie on a group post is no longer "no video in this post":
measured on dev, Facebook answers with its login page (no post id at all), so the
adapter now raises its own POST_NOT_SHOWN verdict and the catalog explains it as
the refused cookie. The adapter owns both post verdicts and the "cannot parse
data" wall wording, so the Chrome retry and the catalog read one constant. The
group-post "no formats" entry is cookie-scoped (with a cookie yt-dlp only gets the
post's video link) and uses the adapter's own group-post test instead of a
"/groups/" substring.
Job transitions that move an asset's ref count (resume, cancel, delete,
redownload) re-read the job under a row lock, asset first, so two overlapping
requests can no longer release the same hold. get_or_create_asset loses an insert
race inside a SAVEPOINT instead of rolling back the caller's pending writes (Retry
lost its cleared error). Every worker-side job failure goes through
finalize_if_running and writes error_detail, so a cancel that landed first is kept
and a failure never shows an earlier one's copy. The worker asks the download
child's own cookie gate (credentials.usable_cookie) when a job inherits a failed
asset.
UI: the Facebook copy no longer points at a Retry button the failure window does
not have, says "paste" like Settings, and the HU wording is fixed
("Újraletöltés" on the re-download confirm). A category this client has no copy
for falls back to the generic sentence instead of a raw key.
Tests: route serialization of error_detail, the probed duration through a real
_download, the page-read cap and a failed read, a Retry off a pending asset, the
confirm-button labels, the lock and savepoint races.
21 lines
1.1 KiB
TypeScript
21 lines
1.1 KiB
TypeScript
import type { DownloadJob } from "./api";
|
|
|
|
// The i18n keys that explain a failed download, most specific first — the list form `t()` takes, so
|
|
// the first key a locale has wins. A failure-catalog entry (`error_detail`, e.g. `facebook.login_wall`)
|
|
// names what went wrong on that site and what to do; the category (`error_code`) is the generic
|
|
// sentence, and the fallback when an older client meets a detail it has no copy for; a category it has
|
|
// no copy for falls back to the unknown one, so the row never prints a key. One helper for the queue
|
|
// row's headline and the failure window, so the two can never explain the same job differently.
|
|
export function failCopyKeys(
|
|
job: Pick<DownloadJob, "error_code" | "error_detail">,
|
|
part: "short" | "body",
|
|
): string[] {
|
|
const category = (code: string) => `downloads.errors.fail.cat.${code}.${part}`;
|
|
const code = job.error_code || "unknown";
|
|
return [
|
|
...(job.error_detail ? [`downloads.errors.fail.catalog.${job.error_detail}.${part}`] : []),
|
|
category(code),
|
|
...(code === "unknown" ? [] : [category("unknown")]),
|
|
];
|
|
}
|