peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
43 lines
1.4 KiB
TypeScript
43 lines
1.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// Every Plex read that returns cards carries the reader's language, so the server can serve the
|
|
// Hungarian titles. The grid and the detail pages always did; these reads did not.
|
|
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
|
|
import { plexApi } from "./plex";
|
|
|
|
const fetchMock = vi.fn();
|
|
|
|
beforeEach(() => {
|
|
fetchMock.mockReset().mockResolvedValue({
|
|
ok: true,
|
|
status: 200,
|
|
headers: new Headers({ "content-type": "application/json" }),
|
|
json: async () => ({}),
|
|
text: async () => "{}",
|
|
});
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
});
|
|
afterEach(() => vi.unstubAllGlobals());
|
|
|
|
const lastUrl = (): string => {
|
|
const calls = fetchMock.mock.calls;
|
|
return String(calls[calls.length - 1]?.[0]);
|
|
};
|
|
|
|
describe("Plex card reads in the reader's language", () => {
|
|
it.each([
|
|
["a playlist", () => plexApi.plexPlaylist(5, "hu"), () => plexApi.plexPlaylist(5, "en")],
|
|
["a person", () => plexApi.plexPerson("Anna", "hu"), () => plexApi.plexPerson("Anna", "en")],
|
|
[
|
|
"a collection",
|
|
() => plexApi.plexCollection("c1", { key: "title", dir: "asc" }, "hu"),
|
|
() => plexApi.plexCollection("c1", { key: "title", dir: "asc" }, "en"),
|
|
],
|
|
])("%s asks for Hungarian, and leaves English implied", async (_what, hu, en) => {
|
|
await hu();
|
|
expect(lastUrl()).toContain("lang=hu");
|
|
await en();
|
|
expect(lastUrl()).not.toContain("lang=");
|
|
});
|
|
});
|