peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
64 lines
2.7 KiB
TypeScript
64 lines
2.7 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { eslint } from "./lintProbe.testkit";
|
|
|
|
// `local/surface-role` (eslint.config.js): a glass surface is a role from ui/surfaces.ts, which brings
|
|
// its radius (docs/DESIGN.md B5). ~140 sites paired three tiers with five radii; this pins
|
|
// that the rule keeping a new one out fires, and where it stands down.
|
|
const RULE = "local/surface-role";
|
|
|
|
async function hits(source: string, filePath = "src/components/__probe.tsx"): Promise<number> {
|
|
const [result] = await eslint.lintText(source, { filePath });
|
|
return (result?.messages ?? []).filter((m) => m.ruleId === RULE).length;
|
|
}
|
|
|
|
describe("a bare glass tier", () => {
|
|
it("is refused in a class string, a template fragment and a ui/ composite", async () => {
|
|
expect(await hits('export const A = () => <div className="glass rounded-2xl p-4" />;\n')).toBe(
|
|
1,
|
|
);
|
|
expect(await hits('export const B = "glass-menu w-60 rounded-xl p-2";\n')).toBe(1);
|
|
expect(await hits("export const C = (x: string) => `glass-card ${x}`;\n")).toBe(1);
|
|
expect(
|
|
await hits(
|
|
'export const D = () => <div className="glass p-3" />;\n',
|
|
"src/components/ui/Toaster.tsx",
|
|
),
|
|
).toBe(1);
|
|
});
|
|
|
|
it("passes as a lone value, through a role, and in the role table itself", async () => {
|
|
expect(await hits('export const E = { variant: "glass" };\n')).toBe(0);
|
|
expect(
|
|
await hits(
|
|
'import { SURFACE } from "./ui/surfaces";\nexport const F = () => <div className={`${SURFACE.card} p-3`} />;\n',
|
|
),
|
|
).toBe(0);
|
|
expect(
|
|
await hits('export const G = "glass rounded-2xl";\n', "src/components/ui/surfaces.ts"),
|
|
).toBe(0);
|
|
});
|
|
});
|
|
|
|
// A role brings its own shadow, whose inset top highlight a `shadow-*` size would replace wholesale.
|
|
describe("a shadow size beside a role", () => {
|
|
const SUR = 'import clsx from "clsx";\nimport { SURFACE } from "./ui/surfaces";\n';
|
|
const tpl = (cls: string) =>
|
|
`${SUR}export const A = () => <div className={\`\${SURFACE.floating} ${cls}\`} />;\n`;
|
|
const call = (role: string, cls: string) =>
|
|
`${SUR}export const B = () => <div className={clsx(SURFACE.${role}, "${cls}")} />;\n`;
|
|
|
|
it("is refused in a template and in clsx, variants included", async () => {
|
|
expect(await hits(tpl("h-12 shadow-lg"))).toBe(1);
|
|
expect(await hits(call("menu", "hover:shadow-2xl"))).toBe(1);
|
|
});
|
|
|
|
it("passes a shadow colour, shadow-float, and a shadow with no role beside it", async () => {
|
|
expect(await hits(tpl("shadow-black/20"))).toBe(0);
|
|
expect(await hits(call("popover", "shadow-float"))).toBe(0);
|
|
expect(await hits('export const E = () => <div className="rounded-lg shadow-lg" />;\n')).toBe(
|
|
0,
|
|
);
|
|
});
|
|
});
|