peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
54 lines
1.8 KiB
TypeScript
54 lines
1.8 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The focus half of the side panels' peek-open model. What is pinned: a dialog opened from inside
|
|
// the panel (rendered at the app root, so outside it in both the DOM and the React tree) does not
|
|
// collapse the panel — collapsing unmounted the row the dialog hands the focus back to, stranding a
|
|
// keyboard user on <body> after Cancel (measured in Chrome).
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { act, cleanup, fireEvent, render, screen } from "@testing-library/react";
|
|
import { useHoverFocusWithin } from "./useHoverFocusWithin";
|
|
|
|
afterEach(cleanup);
|
|
|
|
function Panel() {
|
|
const peek = useHoverFocusWithin();
|
|
return (
|
|
<>
|
|
<div {...peek.focusHandlers} data-testid="panel">
|
|
<button>row</button>
|
|
{peek.active && <span>expanded</span>}
|
|
</div>
|
|
<div role="dialog" aria-modal="true">
|
|
<button>cancel</button>
|
|
</div>
|
|
<button>elsewhere</button>
|
|
</>
|
|
);
|
|
}
|
|
|
|
const moveFocus = (from: HTMLElement, to: HTMLElement) =>
|
|
act(() => {
|
|
fireEvent.blur(from, { relatedTarget: to });
|
|
to.focus();
|
|
});
|
|
|
|
describe("useHoverFocusWithin · focus", () => {
|
|
it("stays open while the focus is in a dialog opened over the page", () => {
|
|
render(<Panel />);
|
|
const row = screen.getByText("row");
|
|
act(() => row.focus());
|
|
expect(screen.queryByText("expanded")).not.toBeNull();
|
|
|
|
moveFocus(row, screen.getByText("cancel"));
|
|
expect(screen.queryByText("expanded")).not.toBeNull();
|
|
});
|
|
|
|
it("still closes when the focus leaves for the page itself", () => {
|
|
render(<Panel />);
|
|
const row = screen.getByText("row");
|
|
act(() => row.focus());
|
|
moveFocus(row, screen.getByText("elsewhere"));
|
|
expect(screen.queryByText("expanded")).toBeNull();
|
|
});
|
|
});
|