peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
28 lines
1.2 KiB
Python
28 lines
1.2 KiB
Python
"""App-assembly smoke test — DB-free.
|
|
|
|
Uses TestClient WITHOUT its context-manager form on purpose: that skips the lifespan (which opens a
|
|
DB session + starts the scheduler), so the app object can be built and its OpenAPI schema generated
|
|
with no database. That alone proves every included router imported and wired cleanly — a broken
|
|
route registration or import fails right here.
|
|
|
|
Endpoints that actually answer (/healthz, /api/version, the auth/feed/downloads routers) all touch
|
|
the database, so exercising THEM belongs in a DB-backed integration lane (needs a test Postgres +
|
|
migrations) — deferred.
|
|
"""
|
|
|
|
from fastapi.testclient import TestClient
|
|
|
|
from app.main import app
|
|
|
|
client = TestClient(app) # no `with` → lifespan/startup does not run → no DB required
|
|
|
|
|
|
def test_app_assembles_and_serves_openapi():
|
|
schema = client.get("/openapi.json")
|
|
assert schema.status_code == 200
|
|
paths = schema.json()["paths"]
|
|
# A handful of endpoints that must always exist — a rename/removal is a real contract change,
|
|
# and their absence here would mean a router failed to register.
|
|
for path in ["/healthz", "/api/version", "/api/feed", "/api/me"]:
|
|
assert path in paths, f"missing route {path} — a router failed to wire up"
|