peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
69 lines
3.2 KiB
Python
69 lines
3.2 KiB
Python
"""DB-backed regression for the 0.53.1 hotfix: GET /api/plex/facets?scope=show
|
|
must return 200 — not the "cannot extract elements from a scalar" 500 — for a metadata-poor
|
|
library whose show has a JSONB-scalar `null` genres (a pre-0.53.1 row). The endpoint's
|
|
`jsonb_typeof(genres)='array'` read-guard is what makes it safe; this test would 500 without it.
|
|
|
|
Uses the DB lane (`db` fixture) — skipped when no Postgres is reachable.
|
|
"""
|
|
|
|
from fastapi.testclient import TestClient
|
|
from sqlalchemy import text
|
|
|
|
import app.state as state
|
|
from app.auth import current_user
|
|
from app.db import get_db
|
|
from app.main import app
|
|
from app.models import PlexItem, PlexLibrary, PlexShow, User
|
|
|
|
|
|
def test_facets_returns_studio_vocabulary(db, monkeypatch, override_dep):
|
|
"""/facets returns the studio vocabulary (distinct studio + count) for the sidebar picker."""
|
|
lib = PlexLibrary(plex_key="1", title="Movies", kind="movie", enabled=True)
|
|
db.add(lib)
|
|
db.flush()
|
|
db.add_all(
|
|
[
|
|
PlexItem(rating_key="m1", library_id=lib.id, kind="movie", title="A", studio="Pixar"),
|
|
PlexItem(rating_key="m2", library_id=lib.id, kind="movie", title="B", studio="Pixar"),
|
|
PlexItem(rating_key="m3", library_id=lib.id, kind="movie", title="C", studio="A24"),
|
|
PlexItem(rating_key="m4", library_id=lib.id, kind="movie", title="D"), # no studio
|
|
]
|
|
)
|
|
user = User(email="studiofacets@example.com")
|
|
db.add(user)
|
|
db.commit()
|
|
monkeypatch.setattr(state, "_configured_cache", True)
|
|
override_dep(get_db, db.info["request"])
|
|
override_dep(current_user, lambda: user)
|
|
resp = TestClient(app).get("/api/plex/facets?scope=movie")
|
|
assert resp.status_code == 200, resp.text
|
|
studios = {s["value"]: s["count"] for s in resp.json()["studios"]}
|
|
assert studios == {"Pixar": 2, "A24": 1}
|
|
|
|
|
|
def test_facets_survives_json_null_genres(db, monkeypatch, override_dep):
|
|
lib = PlexLibrary(plex_key="1", title="Shows", kind="show", enabled=True)
|
|
db.add(lib)
|
|
db.flush()
|
|
db.add(PlexShow(rating_key="s1", library_id=lib.id, title="No Genre Show"))
|
|
user = User(email="facets@example.com")
|
|
db.add(user)
|
|
db.commit()
|
|
# The request gate 503s an unconfigured instance; flip the process-level "configured" flag the
|
|
# gate reads. monkeypatch auto-restores it, so it can't leak "configured" into another test.
|
|
monkeypatch.setattr(state, "_configured_cache", True)
|
|
# Simulate a pre-0.53.1 row: genres persisted as a JSONB scalar `null` (what SQLAlchemy wrote
|
|
# before none_as_null=True), NOT SQL NULL — this is the value jsonb_array_elements_text() chokes
|
|
# on. A Python None now maps to SQL NULL, so we set the scalar directly.
|
|
db.execute(text("UPDATE plex_shows SET genres = 'null'::jsonb WHERE rating_key = 's1'"))
|
|
db.commit()
|
|
|
|
override_dep(get_db, db.info["request"])
|
|
override_dep(current_user, lambda: user)
|
|
client = TestClient(app) # no context-manager: skip lifespan (scheduler/HLS sweep)
|
|
resp = client.get("/api/plex/facets?scope=show")
|
|
|
|
assert resp.status_code == 200, resp.text
|
|
# The scalar-null show contributes no genres — and, crucially, doesn't abort the whole endpoint.
|
|
assert resp.json()["genres"] == []
|