peter
cff8fe9a6a
compilerCoverage.contract.test.ts used to check two files. It now runs the real compiler over all of src (minus tests) and holds the exact set it skips today, file -> function -> category: 93 functions. A new skip or a category change is red, and so is a listed skip that has gone, so the list only shrinks. Channels and DataTable must also show up as compiled, so a harness that compiled nothing cannot pass. Measured against the audit's scan: no function this sprint touched started to skip. PlexPersonView and useOverlayOrder now compile. reactPlugin.ts claimed the compiler's rules were linted, which was false while react-hooks/refs was off. That comment and the refs block in eslint.config.js now say what holds the line and why refs is still off: 245 real hits, pinned by the ratchet, burned down from S3.
41 lines
2.7 KiB
TypeScript
41 lines
2.7 KiB
TypeScript
import react from "@vitejs/plugin-react";
|
|
import reactCompiler from "babel-plugin-react-compiler";
|
|
|
|
// ONE React transform, shared by vite.config.ts and vitest.config.ts (E27 S1).
|
|
//
|
|
// It is a shared factory rather than two `react()` calls because the two configs must not drift:
|
|
// if the compiler ran only in the production build, every vitest run would be exercising code the
|
|
// user never receives, and a compiler-induced behaviour change would ship green. That is precisely
|
|
// the defect `0.93.2` was released to fix — a gate and a build image that had quietly stopped being
|
|
// the same thing — so the rule here is that the gate compiles the code the same way the build does.
|
|
//
|
|
// The React Compiler auto-memoises: it infers what `useCallback`/`useMemo` were being hand-written
|
|
// for and applies the equivalent itself. It is enabled repo-wide with no opt-out list because it
|
|
// bails out on its own for anything it cannot prove safe — SILENTLY: `panicThreshold` is "none" and
|
|
// there is no logger here, so a skipped component still works and simply re-renders everything under
|
|
// it. This comment used to say "its rules are also linted"; it was false while `react-hooks/refs` was
|
|
// off, and 95 functions sat uncompiled behind it (E32). What actually holds the line now is
|
|
// src/components/compilerCoverage.contract.test.ts, which runs THIS compiler over the shipped source
|
|
// and fails on any skip not on its list; the react-hooks lint rules are the early warning, with the
|
|
// one still switched off recorded in docs/gates.md. `target` follows the installed React major and
|
|
// must move with it.
|
|
//
|
|
// The plugin is IMPORTED rather than named by the usual `"babel-plugin-react-compiler"` string. Two
|
|
// reasons, both about the gate: a string is invisible to knip, which then reports the dependency as
|
|
// unused, and — worse — a typo in that string is a silent no-op that ships an uncompiled bundle,
|
|
// while a bad import is a resolve error on the tsc lane.
|
|
//
|
|
// The price of the import: plugin-react finds the compiler only by that string, so it doesn't know the
|
|
// compiler is there. Its one compiler-specific switch is Babel's `retainLines`, which it turns on for
|
|
// dev (and so for vitest) unless the compiler is present. With the compiler's re-printed JSX that eats
|
|
// the space at the end of a text line ("for example <code>" rendered "for example/api/feed"). The
|
|
// production build never had it on. `generatorOpts` wins over the top-level option, so it is switched
|
|
// off here, for every mode. Pinned by src/jsxWhitespace.dom.test.tsx.
|
|
export const reactWithCompiler = () =>
|
|
react({
|
|
babel: {
|
|
plugins: [[reactCompiler, { target: "19" }]],
|
|
generatorOpts: { retainLines: false },
|
|
},
|
|
});
|