peter
f41c81eb56
Deep-review remediation on the frontend, all findings adversarially verified: - LibraryPlayer picks audio vs video from the canonical media_kind (single source), not a hardcoded container whitelist, so an uploaded audio file with an uncommon/absent container renders in <audio> instead of a broken video box (legacy null media_kind keeps the heuristic). - UploadDialog aborts the in-flight upload when the dialog is closed by X/ESC/backdrop/Back (not only the footer Cancel); drag highlight uses an enter/leave depth counter to stop the flicker; the progress bar gets a stable role=progressbar aria-label with the value on aria-valuenow. - DownloadCenter's Shared tab renders honest loading/error states instead of a blank panel, and the library/shared row-action gating moves to a single tested helper (lib/downloadActions). Tests: downloadActions gating matrix, the uploadReq XHR path (abort/401/422-localize/onerror), and the media_kind-driven audio/video branch. i18n: downloads.upload.uploadProgress (HU + EN).
441 lines
18 KiB
TypeScript
441 lines
18 KiB
TypeScript
import { lazy, Suspense, useEffect, useState } from "react";
|
|
import { qk } from "../lib/queryKeys";
|
|
import { useTranslation } from "react-i18next";
|
|
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import {
|
|
Ban,
|
|
ClipboardPaste,
|
|
Download,
|
|
Link2,
|
|
Pause,
|
|
Play,
|
|
PlayCircle,
|
|
Plus,
|
|
RotateCcw,
|
|
Scissors,
|
|
Settings2,
|
|
Share2,
|
|
Pencil,
|
|
Trash2,
|
|
UploadCloud,
|
|
} from "lucide-react";
|
|
import Tabs from "./Tabs";
|
|
import { PageToolbar } from "./PageShell";
|
|
import { LoadingState, StateMessage } from "./QueryState";
|
|
// Lazy: these dialogs/editors open on demand, so they stay out of the Downloads page chunk until
|
|
// used (the video editor in particular is heavy — filmstrip + scrubber).
|
|
const DownloadDialog = lazy(() => import("./DownloadDialog"));
|
|
const UploadDialog = lazy(() => import("./UploadDialog"));
|
|
const ProfileEditor = lazy(() => import("./ProfileEditor"));
|
|
const VideoEditor = lazy(() => import("./VideoEditor"));
|
|
const ShareDialog = lazy(() => import("./ShareDialog"));
|
|
const LibraryPlayer = lazy(() => import("./LibraryPlayer"));
|
|
import { useConfirm } from "./ConfirmProvider";
|
|
import { useLiveQuery } from "../lib/useLiveQuery";
|
|
import { useMe } from "../lib/useMe";
|
|
import { api, type DownloadJob } from "../lib/api";
|
|
import { invalidateDownloads, quickShareLink } from "../lib/downloads";
|
|
import { libraryRowActions, sharedRowActions } from "../lib/downloadActions";
|
|
import { inputCls } from "./ui/form";
|
|
import { Button } from "./ui/Button";
|
|
import { DownloadRow, IconBtn, UsageBar } from "./downloadRow";
|
|
import { MetaEditModal, ErrorModal } from "./downloadModals";
|
|
import { AdminSystem } from "./downloadAdmin";
|
|
|
|
export default function DownloadCenter() {
|
|
const me = useMe();
|
|
const { t } = useTranslation();
|
|
const qc = useQueryClient();
|
|
const confirm = useConfirm();
|
|
// Always land on the queue tab (not a persisted last-tab) — the queue is where new work and
|
|
// any failures are, so it's the useful default every visit.
|
|
const [tab, setTab] = useState("queue");
|
|
const [addUrl, setAddUrl] = useState("");
|
|
const [addSource, setAddSource] = useState<string | null>(null);
|
|
const [upload, setUpload] = useState(false);
|
|
const [manage, setManage] = useState(false);
|
|
const [metaJob, setMetaJob] = useState<DownloadJob | null>(null);
|
|
const [shareJob, setShareJob] = useState<DownloadJob | null>(null);
|
|
const [playJob, setPlayJob] = useState<DownloadJob | null>(null);
|
|
const [editJob, setEditJob] = useState<DownloadJob | null>(null);
|
|
const [errorJob, setErrorJob] = useState<DownloadJob | null>(null);
|
|
|
|
// Poll fast (2s) while work is actually in flight; back off to 15s once the queue is settled
|
|
// (only done/error/paused rows left, which don't advance on their own) so an idle Download Center
|
|
// isn't hitting the API — and adding to the shared box's load — every 2s for nothing.
|
|
const jobsQ = useLiveQuery(qk.downloads(), api.downloads, {
|
|
intervalMs: (data) =>
|
|
data?.some((j) => j.status === "queued" || j.status === "running") ? 2000 : 15000,
|
|
});
|
|
const sharedQ = useQuery({
|
|
queryKey: qk.downloadsShared(),
|
|
queryFn: api.downloadsShared,
|
|
enabled: tab === "shared",
|
|
});
|
|
const jobs = jobsQ.data ?? [];
|
|
const queue = jobs.filter((j) => ["queued", "running", "paused", "error"].includes(j.status));
|
|
const library = jobs.filter((j) => j.status === "done");
|
|
|
|
const invalidate = () => invalidateDownloads(qc);
|
|
const act = useMutation({
|
|
mutationFn: ({
|
|
id,
|
|
op,
|
|
}: {
|
|
id: number;
|
|
op: "pause" | "resume" | "cancel" | "delete" | "redownload";
|
|
}) =>
|
|
op === "pause"
|
|
? api.pauseDownload(id)
|
|
: op === "resume"
|
|
? api.resumeDownload(id)
|
|
: op === "cancel"
|
|
? api.cancelDownload(id)
|
|
: op === "redownload"
|
|
? api.redownloadDownload(id)
|
|
: api.deleteDownload(id),
|
|
onSuccess: invalidate,
|
|
// No onError: a failed job action returns 400/409/422/500, already surfaced by the global
|
|
// error modal (api.ts req) with the backend's specific message — a caller toast would double it.
|
|
});
|
|
|
|
// Remove a shared-with-me item from your list (only your grant; the owner's file is untouched).
|
|
const removeShared = useMutation({
|
|
mutationFn: (id: number) => api.removeSharedDownload(id),
|
|
onSuccess: () => qc.invalidateQueries({ queryKey: qk.downloadsShared() }),
|
|
});
|
|
|
|
const confirmThen = async (title: string, body: string, fn: () => void) => {
|
|
if (await confirm({ title, message: body, confirmLabel: title, danger: true })) fn();
|
|
};
|
|
|
|
// One-click share (E7 S3 · D2-A): ensure a downloadable link, copy it, toast with "open in new tab"
|
|
// (see quickShareLink). Re-clicking reuses the existing link; a per-job in-flight guard also stops a
|
|
// double-click from racing two POSTs into two links before the cache is primed. Advanced controls
|
|
// (password, expiry, revoke, share-with-a-user) live in the Share dialog, via the manage-share button.
|
|
const [sharingId, setSharingId] = useState<number | null>(null);
|
|
const quickShare = async (job: DownloadJob) => {
|
|
if (sharingId !== null) return;
|
|
setSharingId(job.id);
|
|
try {
|
|
await quickShareLink(qc, job, t);
|
|
} finally {
|
|
setSharingId(null);
|
|
}
|
|
};
|
|
|
|
// Pull a link off the clipboard into the add-URL box. Clipboard reads need a secure context +
|
|
// a user gesture/permission (iOS Safari/Brave are strict) — so this is best-effort: the paste
|
|
// button is an explicit gesture (reliable), and the input's onFocus tries silently (ignored if
|
|
// the browser refuses without a click). Only accept an http(s) URL, don't clobber existing text.
|
|
const pasteFromClipboard = async (force = false) => {
|
|
if (!force && addUrl.trim()) return;
|
|
try {
|
|
const text = (await navigator.clipboard?.readText())?.trim();
|
|
if (text && /^https?:\/\/\S+$/i.test(text)) setAddUrl(text);
|
|
} catch {
|
|
/* permission denied or unsupported — the manual paste button still works on a click */
|
|
}
|
|
};
|
|
|
|
const tabs = [
|
|
{ id: "queue", label: t("downloads.tabs.queue"), badge: queue.length },
|
|
{ id: "done", label: t("downloads.tabs.done"), badge: library.length },
|
|
{ id: "shared", label: t("downloads.tabs.shared") },
|
|
...(me.role === "admin" ? [{ id: "system", label: t("downloads.tabs.system") }] : []),
|
|
];
|
|
// Guard against the active tab going away under us (e.g. admin on "system" gets demoted mid-session)
|
|
// — that would render a blank page with no active tab. Fall back to the default.
|
|
useEffect(() => {
|
|
if (!tabs.some((tb) => tb.id === tab)) setTab("queue");
|
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
}, [tab, me.role]);
|
|
|
|
const saveBtn = (job: DownloadJob) => (
|
|
<a
|
|
href={api.downloadFileUrl(job.id)}
|
|
title={t("downloads.actions.download")}
|
|
className="p-1.5 rounded-md hover:bg-surface text-muted hover:text-fg transition"
|
|
>
|
|
<Download className="w-4 h-4" />
|
|
</a>
|
|
);
|
|
|
|
return (
|
|
<>
|
|
{/* Page title + subtitle + tabs are fixed chrome; the tab content scrolls under them. */}
|
|
<PageToolbar>
|
|
<div className="px-4 pt-2 max-w-4xl w-full mx-auto">
|
|
<div className="flex items-center justify-between gap-3 mb-1">
|
|
<h1 className="text-xl font-semibold">{t("downloads.page.title")}</h1>
|
|
<button
|
|
onClick={() => setManage(true)}
|
|
className="inline-flex items-center gap-1.5 px-2.5 py-1.5 rounded-lg text-sm text-muted hover:text-fg hover:bg-surface transition"
|
|
>
|
|
<Settings2 className="w-4 h-4" /> {t("downloads.page.manage")}
|
|
</button>
|
|
</div>
|
|
<p className="text-sm text-muted mb-4">{t("downloads.page.subtitle")}</p>
|
|
|
|
<Tabs tabs={tabs} active={tab} onChange={setTab} />
|
|
</div>
|
|
</PageToolbar>
|
|
|
|
<div className="px-4 pb-4 pt-3 max-w-4xl w-full mx-auto">
|
|
{tab === "queue" && (
|
|
<>
|
|
<div className="flex gap-2 mb-4">
|
|
<input
|
|
value={addUrl}
|
|
onChange={(e) => setAddUrl(e.target.value)}
|
|
onFocus={() => pasteFromClipboard()}
|
|
onKeyDown={(e) => e.key === "Enter" && addUrl.trim() && setAddSource(addUrl.trim())}
|
|
placeholder={t("downloads.page.addUrl")}
|
|
className={inputCls}
|
|
/>
|
|
<Button
|
|
variant="ghost"
|
|
size="sm"
|
|
iconOnly
|
|
icon={<ClipboardPaste className="w-4 h-4" />}
|
|
label={t("downloads.page.paste")}
|
|
onClick={() => pasteFromClipboard(true)}
|
|
className="shrink-0"
|
|
/>
|
|
<Button
|
|
variant="primary"
|
|
size="sm"
|
|
icon={<Plus className="w-4 h-4" />}
|
|
onClick={() => addUrl.trim() && setAddSource(addUrl.trim())}
|
|
className="shrink-0"
|
|
>
|
|
{t("downloads.page.add")}
|
|
</Button>
|
|
{/* Local upload is a peer to "add a URL": a general file → the same library (E7 S5c). */}
|
|
<Button
|
|
variant="outline"
|
|
size="sm"
|
|
icon={<UploadCloud className="w-4 h-4" />}
|
|
onClick={() => setUpload(true)}
|
|
className="shrink-0"
|
|
>
|
|
{t("downloads.page.upload")}
|
|
</Button>
|
|
</div>
|
|
<div className="space-y-2">
|
|
{queue.map((job) => (
|
|
<DownloadRow key={job.id} job={job} onShowError={setErrorJob}>
|
|
{(job.status === "queued" || job.status === "running") && (
|
|
<IconBtn
|
|
onClick={() => act.mutate({ id: job.id, op: "pause" })}
|
|
title={t("downloads.actions.pause")}
|
|
>
|
|
<Pause className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
{(job.status === "paused" || job.status === "error") && (
|
|
<IconBtn
|
|
onClick={() => act.mutate({ id: job.id, op: "resume" })}
|
|
title={t(
|
|
job.status === "error"
|
|
? "downloads.actions.retry"
|
|
: "downloads.actions.resume",
|
|
)}
|
|
>
|
|
<Play className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
<IconBtn
|
|
onClick={() =>
|
|
confirmThen(
|
|
t("downloads.confirm.cancelTitle"),
|
|
t("downloads.confirm.cancelBody"),
|
|
() => act.mutate({ id: job.id, op: "cancel" }),
|
|
)
|
|
}
|
|
title={t("downloads.actions.cancel")}
|
|
danger
|
|
>
|
|
<Ban className="w-4 h-4" />
|
|
</IconBtn>
|
|
</DownloadRow>
|
|
))}
|
|
{queue.length === 0 &&
|
|
(jobsQ.isError && !jobsQ.data ? (
|
|
<StateMessage tone="error" onRetry={() => jobsQ.refetch()}>
|
|
{t("common.loadError")}
|
|
</StateMessage>
|
|
) : jobsQ.isLoading ? (
|
|
<LoadingState />
|
|
) : (
|
|
<div className="text-sm text-muted py-10 text-center">
|
|
{t("downloads.empty.queue")}
|
|
</div>
|
|
))}
|
|
</div>
|
|
</>
|
|
)}
|
|
|
|
{tab === "done" && (
|
|
<>
|
|
<UsageBar />
|
|
<div className="space-y-2">
|
|
{library.map((job) => {
|
|
// Row actions gated on the stored media_kind + job_kind (see downloadActions).
|
|
const a = libraryRowActions(job);
|
|
return (
|
|
<DownloadRow key={job.id} job={job}>
|
|
{a.play && (
|
|
<IconBtn onClick={() => setPlayJob(job)} title={t("downloads.actions.play")}>
|
|
<PlayCircle className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
{saveBtn(job)}
|
|
{a.edit && (
|
|
<IconBtn onClick={() => setEditJob(job)} title={t("downloads.actions.edit")}>
|
|
<Scissors className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
{a.editDetails && (
|
|
<IconBtn
|
|
onClick={() => setMetaJob(job)}
|
|
title={t("downloads.actions.editDetails")}
|
|
>
|
|
<Pencil className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
<IconBtn onClick={() => quickShare(job)} title={t("downloads.actions.share")}>
|
|
<Share2 className="w-4 h-4" />
|
|
</IconBtn>
|
|
<IconBtn
|
|
onClick={() => setShareJob(job)}
|
|
title={t("downloads.actions.shareManage")}
|
|
>
|
|
<Link2 className="w-4 h-4" />
|
|
</IconBtn>
|
|
{a.redownload && (
|
|
<IconBtn
|
|
onClick={() =>
|
|
confirmThen(
|
|
t("downloads.confirm.redownloadTitle"),
|
|
t("downloads.confirm.redownloadBody"),
|
|
() => act.mutate({ id: job.id, op: "redownload" }),
|
|
)
|
|
}
|
|
title={t("downloads.actions.redownload")}
|
|
>
|
|
<RotateCcw className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
<IconBtn
|
|
onClick={() =>
|
|
confirmThen(
|
|
t("downloads.confirm.deleteTitle"),
|
|
t("downloads.confirm.deleteBody"),
|
|
() => act.mutate({ id: job.id, op: "delete" }),
|
|
)
|
|
}
|
|
title={t("downloads.actions.delete")}
|
|
danger
|
|
>
|
|
<Trash2 className="w-4 h-4" />
|
|
</IconBtn>
|
|
</DownloadRow>
|
|
);
|
|
})}
|
|
{library.length === 0 &&
|
|
(jobsQ.isError && !jobsQ.data ? (
|
|
<StateMessage tone="error" onRetry={() => jobsQ.refetch()}>
|
|
{t("common.loadError")}
|
|
</StateMessage>
|
|
) : jobsQ.isLoading ? (
|
|
<LoadingState />
|
|
) : (
|
|
<div className="text-sm text-muted py-10 text-center">
|
|
{t("downloads.empty.done")}
|
|
</div>
|
|
))}
|
|
</div>
|
|
</>
|
|
)}
|
|
|
|
{tab === "shared" && (
|
|
<div className="space-y-2">
|
|
{(sharedQ.data ?? []).map((job) => {
|
|
// Same media_kind + can_download gate as the library, via the shared helper (S5b).
|
|
const a = sharedRowActions(job);
|
|
return (
|
|
<DownloadRow key={job.id} job={job}>
|
|
{a.play && (
|
|
<IconBtn onClick={() => setPlayJob(job)} title={t("downloads.actions.play")}>
|
|
<PlayCircle className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
{a.save && saveBtn(job)}
|
|
{a.edit && (
|
|
<IconBtn onClick={() => setEditJob(job)} title={t("downloads.actions.edit")}>
|
|
<Scissors className="w-4 h-4" />
|
|
</IconBtn>
|
|
)}
|
|
<IconBtn
|
|
onClick={() =>
|
|
confirmThen(
|
|
t("downloads.confirm.removeSharedTitle"),
|
|
t("downloads.confirm.removeSharedBody"),
|
|
() => removeShared.mutate(job.id),
|
|
)
|
|
}
|
|
title={t("downloads.actions.removeShared")}
|
|
danger
|
|
>
|
|
<Trash2 className="w-4 h-4" />
|
|
</IconBtn>
|
|
</DownloadRow>
|
|
);
|
|
})}
|
|
{(sharedQ.data ?? []).length === 0 &&
|
|
(sharedQ.isError && !sharedQ.data ? (
|
|
<StateMessage tone="error" onRetry={() => sharedQ.refetch()}>
|
|
{t("common.loadError")}
|
|
</StateMessage>
|
|
) : sharedQ.isLoading ? (
|
|
<LoadingState />
|
|
) : (
|
|
<div className="text-sm text-muted py-10 text-center">
|
|
{t("downloads.empty.shared")}
|
|
</div>
|
|
))}
|
|
</div>
|
|
)}
|
|
|
|
{tab === "system" && me.role === "admin" && <AdminSystem />}
|
|
|
|
<Suspense fallback={null}>
|
|
{addSource && (
|
|
<DownloadDialog
|
|
source={addSource}
|
|
onClose={() => {
|
|
setAddSource(null);
|
|
setAddUrl("");
|
|
}}
|
|
/>
|
|
)}
|
|
{upload && <UploadDialog onClose={() => setUpload(false)} />}
|
|
{manage && <ProfileEditor onClose={() => setManage(false)} />}
|
|
{metaJob && <MetaEditModal job={metaJob} onClose={() => setMetaJob(null)} />}
|
|
{shareJob && <ShareDialog job={shareJob} onClose={() => setShareJob(null)} />}
|
|
{playJob && <LibraryPlayer job={playJob} onClose={() => setPlayJob(null)} />}
|
|
{editJob && <VideoEditor job={editJob} onClose={() => setEditJob(null)} />}
|
|
{errorJob && (
|
|
<ErrorModal
|
|
job={errorJob}
|
|
onRetry={() => act.mutate({ id: errorJob.id, op: "resume" })}
|
|
onClose={() => setErrorJob(null)}
|
|
/>
|
|
)}
|
|
</Suspense>
|
|
</div>
|
|
</>
|
|
);
|
|
}
|