peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
43 lines
2.1 KiB
TypeScript
43 lines
2.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { eslint } from "./lintProbe.testkit";
|
|
|
|
// The px-frozen BOX rule in eslint.config.js (beside the older `text-[Npx]` one). A `no-restricted-
|
|
// syntax` selector that matches nothing looks exactly like a clean codebase, so pin that it fires.
|
|
|
|
async function refused(source: string): Promise<number> {
|
|
const [result] = await eslint.lintText(source, { filePath: "src/components/__probe.tsx" });
|
|
return (result?.messages ?? []).filter((m) => m.message.startsWith("px-frozen box size")).length;
|
|
}
|
|
|
|
describe("a px-frozen box utility", () => {
|
|
it("is refused in a string and in a template literal", async () => {
|
|
// Assembled, so this file does not trip the very rule it probes.
|
|
const px = (u: string, n: number) => `${u}-[${n}px]`;
|
|
expect(await refused(`export const a = "group ${px("w", 150)} shrink-0";\n`)).toBe(1);
|
|
expect(await refused("export const b = `x ${1} " + px("max-w", 240) + "`;\n")).toBe(1);
|
|
});
|
|
|
|
// A fractional size is as frozen as a whole one: `text-[9.5px]` sat in the Glass tuner past an
|
|
// integer-only pattern (debt burn 2026-09).
|
|
it("is refused with a fractional size, for a box and for a font", async () => {
|
|
const px = (u: string, n: number) => `${u}-[${n}px]`;
|
|
expect(await refused(`export const e = "${px("w", 12.5)}";\n`)).toBe(1);
|
|
const [font] = await eslint.lintText(`export const f = "${px("text", 9.5)}";\n`, {
|
|
filePath: "src/components/__probe.tsx",
|
|
});
|
|
expect(font?.messages.some((m) => m.message.startsWith("px-frozen font size"))).toBe(true);
|
|
});
|
|
|
|
it("is refused as a grid column's minimum", async () => {
|
|
const mm = (n: string) => `grid-cols-[repeat(auto-fill,minmax(${n},1fr))]`;
|
|
expect(await refused(`export const g = "grid ${mm("150px")}";\n`)).toBe(1);
|
|
expect(await refused(`export const h = "grid ${mm("9.375rem")}";\n`)).toBe(0);
|
|
});
|
|
|
|
it("leaves the spacing scale, a rem arbitrary and a grid track alone", async () => {
|
|
expect(await refused('export const c = "w-37.5 max-w-60 text-[0.75rem]";\n')).toBe(0);
|
|
expect(await refused('export const d = "grid-cols-[1fr_240px]";\n')).toBe(0);
|
|
});
|
|
});
|