peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
29 lines
1.1 KiB
TypeScript
29 lines
1.1 KiB
TypeScript
import { test, expect } from "@playwright/test";
|
|
import { openApp, openFirstVideo } from "./helpers";
|
|
|
|
// Locks the in-app player's open/close contract. The player is a portaled overlay whose
|
|
// inconsistent mounting caused a regression — exactly the kind of thing the refactor's
|
|
// overlay-root convention must not break. We assert the modal shell, not YouTube playback.
|
|
test.describe("player modal", () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
// Hermetic: don't actually load the YouTube iframe/player.
|
|
await page.route(/youtube\.com/, (route) => route.abort());
|
|
});
|
|
|
|
test("opens from a card and closes via the close button", async ({ page }) => {
|
|
await openApp(page);
|
|
await openFirstVideo(page);
|
|
|
|
await page.getByTestId("player-close").click();
|
|
await expect(page.getByTestId("player-modal")).toHaveCount(0);
|
|
});
|
|
|
|
test("closes on Escape", async ({ page }) => {
|
|
await openApp(page);
|
|
await openFirstVideo(page);
|
|
|
|
await page.keyboard.press("Escape");
|
|
await expect(page.getByTestId("player-modal")).toHaveCount(0);
|
|
});
|
|
});
|