peter
5f09259bbf
B-core-3 (2026-08-17 review): decouple two things from router modules. 1. Feed read-model → new app/feedquery.py: the pure query-building and row-serialization layer (feed_columns, serialize, _filtered_query, to_tsquery_str, and the keyset-pagination helpers) moves out of routes/feed.py, which keeps only the route handlers, _feed_params, and the request models. The three external consumers (playlists, search, plex/browse) now import from app.feedquery instead of reaching into the feed router. 2. admin_user sweep: 7 modules imported admin_user via app.routes.admin (an incidental re-export of app.auth.admin_user). Repoint them all to the definition in app.auth (audit, channels, config, quota, scheduler, plex/admin, plex/browse); routes.admin keeps its own import for its use. Pure code motion — no behaviour change. Full DB-lane suite 287 passed / 2 skipped; ruff clean.
73 lines
2.6 KiB
Python
73 lines
2.6 KiB
Python
"""Admin audit log API: read the append-only who/what/when trail, and clear it.
|
|
|
|
Admin-only. The client renders these rows in a DataTable (client-side sort/filter/paginate), so
|
|
this returns the most recent window of rows (capped) plus the true total, rather than paging
|
|
server-side — the log stays small in practice (state-changing runs + admin actions only)."""
|
|
from fastapi import APIRouter, Depends
|
|
from sqlalchemy import delete, func, select
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app import audit
|
|
from app.audit import AuditAction
|
|
from app.auth import admin_user
|
|
from app.db import get_db
|
|
from app.models import AuditLog, User
|
|
from app.utils import iso
|
|
|
|
router = APIRouter(prefix="/api/admin/audit", tags=["admin"])
|
|
|
|
# Cap the client-side window. The audit log is small by design; if it ever outgrows this we'd
|
|
# switch the DataTable to server-side paging.
|
|
MAX_ROWS = 2000
|
|
|
|
|
|
def _serialize(row: AuditLog, actors: dict[int, str]) -> dict:
|
|
return {
|
|
"id": row.id,
|
|
"created_at": iso(row.created_at),
|
|
# actor_id NULL = the scheduler/background did it (client shows "System"); a set id that
|
|
# can't be resolved would mean a deleted user, but SET NULL makes that NULL — so present.
|
|
"actor": actors.get(row.actor_id) if row.actor_id is not None else None,
|
|
"action": row.action,
|
|
"target_type": row.target_type,
|
|
"target_id": row.target_id,
|
|
"summary": row.summary,
|
|
"before": row.before,
|
|
"after": row.after,
|
|
}
|
|
|
|
|
|
@router.get("")
|
|
def list_audit(
|
|
limit: int = 500,
|
|
_: User = Depends(admin_user),
|
|
db: Session = Depends(get_db),
|
|
) -> dict:
|
|
limit = max(1, min(limit, MAX_ROWS))
|
|
total = db.scalar(select(func.count()).select_from(AuditLog)) or 0
|
|
rows = (
|
|
db.execute(select(AuditLog).order_by(AuditLog.created_at.desc()).limit(limit))
|
|
.scalars()
|
|
.all()
|
|
)
|
|
actor_ids = {r.actor_id for r in rows if r.actor_id is not None}
|
|
actors: dict[int, str] = {}
|
|
if actor_ids:
|
|
actors = dict(
|
|
db.execute(select(User.id, User.email).where(User.id.in_(actor_ids))).all()
|
|
)
|
|
return {
|
|
"items": [_serialize(r, actors) for r in rows],
|
|
"total": total,
|
|
"returned": len(rows),
|
|
}
|
|
|
|
|
|
@router.delete("")
|
|
def clear_audit(admin: User = Depends(admin_user), db: Session = Depends(get_db)) -> dict:
|
|
"""Clear the audit log. Leaves ONE row recording who cleared it + how many (tamper-evidence)."""
|
|
n = db.execute(delete(AuditLog)).rowcount or 0
|
|
audit.record(db, admin.id, AuditAction.AUDIT_CLEAR, summary=f"Cleared {n} audit entries")
|
|
db.commit()
|
|
return {"cleared": n}
|