peter
e7f38396a2
Deep-review round 3 over main..improvement/watch-background-audio. Account boot - The notification history and settings, and the hints toggle, are read when their modules load, which in a new tab (bookmark, typed URL) is before BootGate pins the account: they read as nobody's, and the tab's first notice replaced the account's stored history (up to 100 entries) with a one-item list. They now read again when the tab is pinned (onAccountPinned, run by setActiveAccount); a notice raised before the pin stays, after the history. - A tab pinned to an account still in this browser's wallet but whose session ended (suspended, deleted, or revoked by "log out everywhere") got "signed out" from /api/me while the default account was still signed in, and signing in again as anyone else left it there. A refused per-tab account now leaves the wallet, and the probe answers as the default, so the tab reloads onto it. Share page (/watch) - The password unlock is limited per viewer (link + client IP), under a per-link ceiling that counts only wrong passwords. Keyed on the link alone, ten wrong guesses every five minutes locked out every viewer, the ones with the password included. client_ip moves to app.ratelimit so the public routes can key on it. - Its failure messages and the load-failure screen are announced (role=alert, the password input described by its error). The sign-in, passphrase, password-change and setup form errors get role=alert too. Comments that still described removed machinery are corrected: App's collapse flags, SettingsPanel's Save bar, ConfigPanel, authed_format_sig. Tests: the account's history and hints across the pin; a revoked and a suspended pinned account; the per-viewer limit and the ceiling; the limiter's exhausted(); the share page's announced failures; a share link's feed filters persisted. Each mutation-checked RED for its own reason.
23 lines
927 B
TypeScript
23 lines
927 B
TypeScript
// App-wide "hints" toggle: when on, Tooltip components reveal short explanatory
|
|
// captions on hover so the UI is somewhat self-documenting for new users. Experienced
|
|
// users can turn it off in Settings. Persisted to localStorage (+ server preferences).
|
|
import { onAccountPinned } from "./activeAccount";
|
|
import { createStore } from "./store";
|
|
import { getAccountRaw, LS, setAccountRaw } from "./storage";
|
|
|
|
function load(): boolean {
|
|
return getAccountRaw(LS.hints) !== "0"; // default ON (also when the account isn't known yet)
|
|
}
|
|
|
|
const store = createStore<boolean>(load());
|
|
// Read at import — in a new tab, before BootGate pins the account — so read again once it is pinned.
|
|
onAccountPinned(() => store.set(load()));
|
|
|
|
export const hintsEnabled = store.get;
|
|
export const subscribeHints = store.subscribe;
|
|
|
|
export function setHintsEnabled(v: boolean): void {
|
|
store.set(v);
|
|
setAccountRaw(LS.hints, v ? "1" : "0");
|
|
}
|