The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
107 lines
3.5 KiB
TypeScript
107 lines
3.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { act, cleanup, render } from "@testing-library/react";
|
|
import { useRef, useState } from "react";
|
|
|
|
import { focusNeighbour, useFocusKeeper } from "./useFocusKeeper";
|
|
|
|
afterEach(cleanup);
|
|
|
|
const flush = () => act(() => new Promise((r) => setTimeout(r, 0)));
|
|
|
|
function Rows({ nav = false }: { nav?: boolean }) {
|
|
const ref = useRef<HTMLDivElement>(null);
|
|
useFocusKeeper(ref);
|
|
const [rows, setRows] = useState(["a", "b", "c"]);
|
|
return (
|
|
<div ref={ref}>
|
|
<h2>Invites</h2>
|
|
{rows.map((r, i) => (
|
|
<div key={r} {...(nav ? { "data-nav-index": i } : {})}>
|
|
<button onClick={() => setRows((xs) => xs.filter((x) => x !== r))}>approve {r}</button>
|
|
</div>
|
|
))}
|
|
<button>after the list</button>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const btn = (name: string) =>
|
|
[...document.querySelectorAll("button")].find((b) => b.textContent === name)!;
|
|
|
|
describe("useFocusKeeper", () => {
|
|
it("keeps the focus in the removed row's slot — the next row takes it", async () => {
|
|
render(<Rows />);
|
|
btn("approve b").focus();
|
|
act(() => btn("approve b").click());
|
|
await flush();
|
|
expect(document.activeElement).toBe(btn("approve c"));
|
|
});
|
|
|
|
it("falls back to what followed the list once the last row is gone", async () => {
|
|
render(<Rows />);
|
|
btn("approve c").focus();
|
|
act(() => btn("approve c").click());
|
|
await flush();
|
|
expect(document.activeElement).toBe(btn("after the list"));
|
|
});
|
|
|
|
// A page swapped for its loading fallback leaves nothing focusable in the slot. The walk up used to
|
|
// run past the container and hand the focus to the first control of the whole document.
|
|
it("never puts the focus outside its own container", async () => {
|
|
function Swapped() {
|
|
const ref = useRef<HTMLDivElement>(null);
|
|
useFocusKeeper(ref);
|
|
const [loaded, setLoaded] = useState(true);
|
|
return (
|
|
<>
|
|
<button>rail</button>
|
|
<div ref={ref}>
|
|
{loaded ? <button onClick={() => setLoaded(false)}>go</button> : <p>Loading…</p>}
|
|
</div>
|
|
</>
|
|
);
|
|
}
|
|
render(<Swapped />);
|
|
btn("go").focus();
|
|
act(() => btn("go").click());
|
|
await flush();
|
|
expect(document.activeElement).toBe(document.body);
|
|
});
|
|
|
|
it("leaves a keyboard list's rows to listNav", async () => {
|
|
render(<Rows nav />);
|
|
btn("approve b").focus();
|
|
act(() => btn("approve b").click());
|
|
await flush();
|
|
expect(document.activeElement).toBe(document.body);
|
|
});
|
|
});
|
|
|
|
describe("focusNeighbour", () => {
|
|
// The neighbour of the hidden-filter cue's chip is the table's first header button — the
|
|
// hidden column's own, `display: none`, which refuses focus(): the focus fell to <body>. jsdom paints
|
|
// nothing, so `checkVisibility` is stood in for, answering for the one hidden button.
|
|
it("passes over a focusable the CSS has taken off screen", () => {
|
|
render(
|
|
<div>
|
|
<div>
|
|
<button>chip</button>
|
|
</div>
|
|
<button data-off="">hidden header</button>
|
|
<button>shown header</button>
|
|
</div>,
|
|
);
|
|
Object.defineProperty(HTMLElement.prototype, "checkVisibility", {
|
|
configurable: true,
|
|
value(this: HTMLElement) {
|
|
return !this.hasAttribute("data-off");
|
|
},
|
|
});
|
|
btn("chip").focus();
|
|
expect(focusNeighbour(btn("chip"))).toBe(true);
|
|
expect(document.activeElement).toBe(btn("shown header"));
|
|
delete (HTMLElement.prototype as Partial<HTMLElement>).checkVisibility;
|
|
});
|
|
});
|