peter
332d24a646
Every one of them is the same shape: a value derived correctly, and a WRITE to the thing it derives from left unattended. Deriving hides a stale value; it does not consume it. PlayerModal — the watch toggle inherited the previous video's auto-watch. Moving the queue-advance sync into render was right for `currentVideoId`, but the same block also synced `status`, and that one had an ordering constraint of its own: useYtProgress's cleanup for the OUTGOING item can still call setWatched(true) near the end of a clip, and cleanups run after the commit. As an effect the sync landed last and corrected it; from render it lands first and the stray write wins. Press Next in the final ten seconds and the NEXT video showed as watched — one click on the toggle then sent onState(next, "new") for an item already new. Fixed by keying the mirror to the id it describes, so a write for another item is ignored rather than displayed, and no ordering has to be argued about at all. ChannelsProvider — a focus-channel intent was masked by the page rather than consumed, and nothing ever cleared it. The manager is a page chunk: it unmounts on every navigation, and its seed effect runs again on each mount, so returning to it re-applied a channel name from earlier in the session over whatever the user had typed since. The consumed marker now lives in the provider, keyed on the token — which also closes the case the old clear-on-leave effect never handled, opening a channel page (that does not change `page` at all). TagFilterChips + ChannelTags x2 — `open = openRaw && hidden > 0` hides the overflow popover when the lane stops overflowing, but floating-ui only reports a close for a real event on a mounted surface, so the raw flag stayed true and the menu came back by itself on the next re-fit — a window resize or the text-size slider is enough, with nobody near it. The flag is now reset in render against the same condition that hides it. Avatar + downloadRow — remembering a failed image BY URL fixed the recycled-row frame but never forgot it, so a transient 429 pinned a channel to its initial for the life of the instance, never re-requesting. The memory is now dropped once `src` moves off it, which keeps both properties. And playerModalHooks' last exhaustive-deps suppression claimed "nothing in the body reads a render value" while reading five. The invariant that is actually load-bearing is that each of them is a per-item snapshot — written down instead. All four fixes are mutation-checked: each new test was seen red, against the fixed line only, naming the real defect.
79 lines
3.3 KiB
TypeScript
79 lines
3.3 KiB
TypeScript
import { createContext, useContext } from "react";
|
|
import type { ChannelLayout } from "../lib/channelLayout";
|
|
import type { SortState } from "../lib/columnSort";
|
|
import type { FilterMap } from "../lib/tableColumns";
|
|
import type { ChannelsView } from "./Channels";
|
|
|
|
// The Channels module's contexts + hooks, split out of ChannelsProvider so that file exports only
|
|
// components (Fast Refresh). The provider owns the state; this is the read side every consumer imports.
|
|
|
|
export type ChannelsState = {
|
|
search: string;
|
|
// The subscribed table's column filters, lifted out of DataTable so the top status chips, the Sync
|
|
// column funnel, and the card layout share ONE filter state (the sync chip lives at `filters.sync`).
|
|
filters: FilterMap;
|
|
view: ChannelsView;
|
|
// The subscribed table's sort, lifted out of DataTable so the card layout shares it.
|
|
sort: SortState;
|
|
// Bumped to tell the manager to drop a stale column filter when an intent sends the user to a
|
|
// specific set (the header's "without full history" link).
|
|
filtersResetToken: number;
|
|
focusName: string | null;
|
|
// Bumped every time a focus intent is (re-)issued, so re-focusing the same channel re-seeds the
|
|
// manager's name filter even when the name is unchanged.
|
|
focusToken: number;
|
|
};
|
|
|
|
export interface ChannelsActions {
|
|
setSearch: (q: string) => void;
|
|
setFilters: (f: FilterMap) => void;
|
|
setView: (v: ChannelsView) => void;
|
|
setLayout: (l: ChannelLayout) => void;
|
|
setSort: (s: SortState) => void;
|
|
// "Focus this channel in the manager": jump to Channels (subscriptions tab) and seed its name
|
|
// filter so the channel is isolated. Called from the feed sidebar and the notifications inbox.
|
|
focusChannel: (name: string) => void;
|
|
// Mark the current focus intent as applied. The manager calls this the moment it seeds its name
|
|
// filter, so the intent cannot be re-applied when the page chunk remounts on a later visit and
|
|
// overwrite a search the user has typed since.
|
|
consumeFocus: () => void;
|
|
// Jump to the manager filtered to channels still missing full history (the header sync chip).
|
|
goToFullHistory: () => void;
|
|
}
|
|
|
|
export const ChannelsStateContext = createContext<ChannelsState>({
|
|
search: "",
|
|
filters: {},
|
|
view: "subscribed",
|
|
sort: null,
|
|
filtersResetToken: 0,
|
|
focusName: null,
|
|
focusToken: 0,
|
|
});
|
|
// The table/cards density gets its OWN context, deliberately narrow: App reads it (to decide the
|
|
// shell's top fade) and would otherwise re-render the whole app on every keystroke in the manager's
|
|
// search box, since the state context above changes with it.
|
|
export const ChannelLayoutContext = createContext<ChannelLayout>("table");
|
|
export const ChannelsActionsContext = createContext<ChannelsActions>({
|
|
setSearch: () => {},
|
|
setFilters: () => {},
|
|
setView: () => {},
|
|
setLayout: () => {},
|
|
setSort: () => {},
|
|
focusChannel: () => {},
|
|
consumeFocus: () => {},
|
|
goToFullHistory: () => {},
|
|
});
|
|
|
|
export function useChannels(): ChannelsState {
|
|
return useContext(ChannelsStateContext);
|
|
}
|
|
/** The manager's table/cards density on its own — subscribe to this instead of the whole state when
|
|
* the layout is all you need (App does, for the shell's top fade). */
|
|
export function useChannelLayout(): ChannelLayout {
|
|
return useContext(ChannelLayoutContext);
|
|
}
|
|
export function useChannelsActions(): ChannelsActions {
|
|
return useContext(ChannelsActionsContext);
|
|
}
|