peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
65 lines
2.5 KiB
TypeScript
65 lines
2.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The tab rail was a row of `aria-pressed` toggle buttons — every tab a Tab stop, no
|
|
// arrow keys, and nothing tying a tab to the content it shows. It is an ARIA tab list now.
|
|
import { useState } from "react";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
|
import Tabs from "./Tabs";
|
|
import { useTabPanel } from "./tabPanel";
|
|
|
|
afterEach(cleanup);
|
|
|
|
const TABS = [
|
|
{ id: "a", label: "Alpha" },
|
|
{ id: "b", label: "Beta" },
|
|
{ id: "c", label: "Gamma" },
|
|
];
|
|
|
|
function Harness() {
|
|
const [active, setActive] = useState("a");
|
|
const panel = useTabPanel();
|
|
return (
|
|
<>
|
|
<Tabs idBase={panel.idBase} tabs={TABS} active={active} onChange={setActive} label="Pick" />
|
|
<div {...panel.panelProps(active)}>content of {active}</div>
|
|
</>
|
|
);
|
|
}
|
|
|
|
const tab = (name: string) => screen.getByRole("tab", { name });
|
|
|
|
describe("Tabs", () => {
|
|
it("is a tab list with one Tab stop, the selected tab", () => {
|
|
render(<Harness />);
|
|
expect(screen.getByRole("tablist", { name: "Pick" })).toBeTruthy();
|
|
expect(tab("Alpha").getAttribute("aria-selected")).toBe("true");
|
|
expect(tab("Beta").getAttribute("aria-selected")).toBe("false");
|
|
expect(TABS.map((t) => tab(t.label).tabIndex)).toEqual([0, -1, -1]);
|
|
});
|
|
|
|
it("moves and selects with the arrows, and Home/End jump to the ends", () => {
|
|
render(<Harness />);
|
|
tab("Alpha").focus();
|
|
fireEvent.keyDown(document.activeElement!, { key: "ArrowRight" });
|
|
expect(document.activeElement).toBe(tab("Beta"));
|
|
expect(tab("Beta").getAttribute("aria-selected")).toBe("true");
|
|
fireEvent.keyDown(document.activeElement!, { key: "End" });
|
|
expect(document.activeElement).toBe(tab("Gamma"));
|
|
fireEvent.keyDown(document.activeElement!, { key: "ArrowRight" }); // wraps
|
|
expect(document.activeElement).toBe(tab("Alpha"));
|
|
fireEvent.keyDown(document.activeElement!, { key: "ArrowUp" }); // either axis
|
|
expect(document.activeElement).toBe(tab("Gamma"));
|
|
fireEvent.keyDown(document.activeElement!, { key: "Home" });
|
|
expect(tab("Alpha").getAttribute("aria-selected")).toBe("true");
|
|
});
|
|
|
|
it("ties each tab to the panel, and the panel to the selected tab", () => {
|
|
render(<Harness />);
|
|
const panel = screen.getByRole("tabpanel");
|
|
expect(tab("Beta").getAttribute("aria-controls")).toBe(panel.id);
|
|
fireEvent.click(tab("Beta"));
|
|
expect(screen.getByRole("tabpanel", { name: "Beta" })).toBe(panel);
|
|
});
|
|
});
|