fix(e4): address code-review findings (a11y sweep + dedup guards)

Resolves the 5 /code-review high findings on this branch:
- a11y sweep: extend aria-label to the remaining icon-only Plex card buttons the
  first pass missed — PlexPosterCard Info, SeasonCard watched-toggle + add-season
  (EpisodeCard already had them). "Fix a principle everywhere, in one sweep."
- new shared lib/parseId.ts `parsePositiveIntId`, used by BOTH readSelectedId
  (now guarding the stored ?pl fallback the same as the URL — was unguarded) and
  plexSubUrl's ?v=playlist decode; removes the hand-duplicated guard.
- PAGE_KEY exported from navigationInit and imported by NavigationProvider (was
  defined in both).
- hoist a `watchedLabel` const per card so title + aria-label can't drift.

+8 tests (parseId unit + guarded-stored ?pl); full FE gate green (tsc/eslint/
prettier/knip, 317 vitest).

This commit is contained in:

peter

2026-08-20 05:40:59 +02:00

parent 0b7180ce8f

commit 482dd28006

8 changed files with 68 additions and 23 deletions

									
										frontend/src/components/navigationInit.ts
									
		+1
		-1
	
												View File
												
				@@ -5,7 +5,7 @@

				import { hasFilterParams, isPage, readPage, type Page } from "../lib/urlState";

				import { getAccountRaw, LS } from "../lib/storage";

				const PAGE_KEY = LS.page;

				export const PAGE_KEY = LS.page;

				export interface ChannelView {

				  id: string;