fix(ui,i18n): E30 review round 2 — honest bio failure, a full show summary, one HU name per thing
- Person page: a bio ask that fails says so with a retry instead of reading as 'no biography'. - Show page: the summary is a ClampedText (5 lines + More), like the person and collection pages; one More/Less pair (plex.textMore/textLess) for all three. - Channels: a re-slotted row is placed in the language the server orders by (the stored preference, else English), not the UI's guess. - A skipped run's body is only the reason (its title already says skipped). - HU: Behúzási kvótatartalék; Eseménynapló ürítve / az eseménynaplót; indok; közvetlenül játszható / közvetlen közvetítés in the Plex hints. - Tests: ClampedText re-measures on a resize, the show summary clamp, serverOrderLang.
This commit is contained in:
@@ -40,7 +40,7 @@ export function jobResultText(t: TFunction, result: JobResult, lang: string): st
|
||||
|
||||
/** What a job run said, as the inbox notice and the audit row both show it (E30): a title naming the job
|
||||
* and how the run ended, and its result in the reader's language — from the data when it rode along,
|
||||
* else read back from the English one-liner. A run skipped for a pause names why; a failed run keeps the
|
||||
* else read back from the English one-liner. A skipped run names only why; a failed run keeps the
|
||||
* upstream's own error text (it is diagnostic). */
|
||||
export function jobRunText(
|
||||
t: TFunction,
|
||||
@@ -63,8 +63,21 @@ export function jobRunText(
|
||||
: (parseSummary(summary) ??
|
||||
(run.status === "skipped" && summary ? { skipped: summary } : null));
|
||||
}
|
||||
// A skipped run's title already says "skipped": its body is only the reason, not "skipped: <reason>".
|
||||
const reason = run.status === "skipped" ? onlySkipReason(result) : null;
|
||||
return {
|
||||
title: t(titleKey, { job }),
|
||||
body: result ? jobResultText(t, result, lang) : summary,
|
||||
body:
|
||||
reason !== null
|
||||
? t(`scheduler.skip.${vocabKey(reason)}`, { defaultValue: reason })
|
||||
: result
|
||||
? jobResultText(t, result, lang)
|
||||
: summary,
|
||||
};
|
||||
}
|
||||
|
||||
function onlySkipReason(result: JobResult | null): string | null {
|
||||
const keys = result ? Object.keys(result) : [];
|
||||
const word = result?.skipped;
|
||||
return keys.length === 1 && typeof word === "string" ? word : null;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user