2 Commits

Include renames

Author	SHA1	Message	Date
peter	332d24a646	fix(frontend): four state defects the deep-review found in the E27 S2 sweep ... Every one of them is the same shape: a value derived correctly, and a WRITE to the thing it derives from left unattended. Deriving hides a stale value; it does not consume it. PlayerModal — the watch toggle inherited the previous video's auto-watch. Moving the queue-advance sync into render was right for `currentVideoId`, but the same block also synced `status`, and that one had an ordering constraint of its own: useYtProgress's cleanup for the OUTGOING item can still call setWatched(true) near the end of a clip, and cleanups run after the commit. As an effect the sync landed last and corrected it; from render it lands first and the stray write wins. Press Next in the final ten seconds and the NEXT video showed as watched — one click on the toggle then sent onState(next, "new") for an item already new. Fixed by keying the mirror to the id it describes, so a write for another item is ignored rather than displayed, and no ordering has to be argued about at all. ChannelsProvider — a focus-channel intent was masked by the page rather than consumed, and nothing ever cleared it. The manager is a page chunk: it unmounts on every navigation, and its seed effect runs again on each mount, so returning to it re-applied a channel name from earlier in the session over whatever the user had typed since. The consumed marker now lives in the provider, keyed on the token — which also closes the case the old clear-on-leave effect never handled, opening a channel page (that does not change `page` at all). TagFilterChips + ChannelTags x2 — `open = openRaw && hidden > 0` hides the overflow popover when the lane stops overflowing, but floating-ui only reports a close for a real event on a mounted surface, so the raw flag stayed true and the menu came back by itself on the next re-fit — a window resize or the text-size slider is enough, with nobody near it. The flag is now reset in render against the same condition that hides it. Avatar + downloadRow — remembering a failed image BY URL fixed the recycled-row frame but never forgot it, so a transient 429 pinned a channel to its initial for the life of the instance, never re-requesting. The memory is now dropped once `src` moves off it, which keeps both properties. And playerModalHooks' last exhaustive-deps suppression claimed "nothing in the body reads a render value" while reading five. The invariant that is actually load-bearing is that each of them is a per-item snapshot — written down instead. All four fixes are mutation-checked: each new test was seen red, against the fixed line only, naming the real defect.	2026-09-21 23:32:22 +02:00
peter	7e1aeeb9fe	refactor(frontend): honest effect deps in the app shell and the ui layer (E27 S2) ... Burns the first 14 of the 113 hook suppressions. Three verdicts, applied per site: A useEffect that should not exist (6): - Avatar remembered "the image failed" as a boolean an effect reset on src change. The component is recycled across items in the virtualized feed, so after one avatar 429s the next item's slot committed the fallback initial over a perfectly good image and only the post-paint effect cleared it. The failure is now keyed BY URL; derived state cannot be stale. - Combobox cleared the typed query from an effect on `open`. Moved into setOpenAnd, the single funnel every close goes through. That also stops a spurious onQueryChange("") AT MOUNT, which told a controlled caller its own initial query had been cleared before the user touched it. - CommandPalette reset query + picked row from an effect. Closed now means UNMOUNTED, not hidden, so a fresh open starts blank because mounting already means that -- and the ranking memo over every channel, playlist and saved view stops running while the palette is shut. - Pager's page box held a copy of the page that an effect re-synced; it now derives it and keeps a draft only while being edited. - App's ?link= / ?oauth= / ?admin= one-shots asserted "once per mount" with an empty dep list. The ref guard the codebase already uses in 22 places ENFORCES it, so the honest deps can include `t` -- which a language switch legitimately changes, and which would otherwise have re-fired the toast. Honest deps that also fix something (5): - App's module preload was keyed on the account id, so a permission change that alters the module set without moving the id never re-preloaded. `preload()` is idempotent, so depending on `me` costs nothing. - App's access-request nudge now re-issues on a language switch; it used to stay in the old language until the pending count changed. - App's diagnostics effect: applyDiagnostics already no-ops on an unchanged effective level, so picking four fields out by hand was guarding nothing and missed any field added later. - DataTable's two filter effects: a ref holds the latest onFiltersChange so commitFilters can be stable, which is what lets the effects name it instead of switching the check off. Genuine escape hatches (7) moved OUT of eslint-suppressions.json into inline directives that name the invariant at the site -- the toast handover's render-phase global, the live region's deliberate arming tick, the docked one-slot component, the popover engine's floating-ui list state, dnd-kit's per-drag `moved` flag, BackToTop's DOM read and the palette's debounced announcement. A reader of the code now sees why; a JSON file no one opens does not. Tests: Avatar (3, new file) and Pager (3) pin the derived-state frames with a layout-phase probe -- layout effects run before any passive effect, so they read the frame the browser would paint. Combobox (2) pins the close-clears-query contract and the no-callback-at-mount rule. All three sets mutation-checked against the effect-based originals. Suppressions 113 -> 99; exhaustive-deps 45 -> 35.	2026-09-20 23:57:08 +02:00