peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
32 lines
1.3 KiB
Python
32 lines
1.3 KiB
Python
"""Plex card serializers (app.plex.cards) — pure model->dict projections, no DB needed.
|
|
|
|
Movie/show cards now also emit `art` (the wide backdrop, for a Discover rail's landscape tile
|
|
and the crossfading hero), but ONLY when the item actually has an `art_key` — otherwise the URL would
|
|
resolve to a blank image on every card that tried to use it, so it must be null and let the client fall
|
|
back to the poster."""
|
|
|
|
from app.models import PlexItem, PlexShow
|
|
from app.plex.cards import movie_card, show_card
|
|
|
|
|
|
def test_movie_card_emits_art_when_art_key_present():
|
|
it = PlexItem(rating_key="m1", kind="movie", title="M", year=2020, art_key="/library/art/1")
|
|
card = movie_card(it, None, lang="en")
|
|
assert card["thumb"] == "/api/plex/image/m1"
|
|
assert card["art"] == "/api/plex/image/m1?variant=art"
|
|
|
|
|
|
def test_movie_card_art_is_none_without_art_key():
|
|
it = PlexItem(rating_key="m2", kind="movie", title="M2")
|
|
assert movie_card(it, None, lang="en")["art"] is None
|
|
|
|
|
|
def test_show_card_emits_art_when_art_key_present():
|
|
sh = PlexShow(rating_key="s1", title="S", art_key="/library/art/2")
|
|
assert show_card(sh, lang="en")["art"] == "/api/plex/image/s1?variant=art"
|
|
|
|
|
|
def test_show_card_art_is_none_without_art_key():
|
|
sh = PlexShow(rating_key="s2", title="S2")
|
|
assert show_card(sh, lang="en")["art"] is None
|