peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
46 lines
2.0 KiB
TypeScript
46 lines
2.0 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// Owner's call: a page's sub-tab was remembered forever in localStorage, so every fresh browser tab
|
|
// opened Configuration on "Plex" as if that were its home. The position is now kept per browser tab
|
|
// (sessionStorage): it survives a reload and a trip to another page, and a new tab starts on the first.
|
|
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
|
import { act, renderHook } from "@testing-library/react";
|
|
import { ACTIVE_ACCOUNT_KEY } from "./activeAccount";
|
|
import { setTabRaw, useTabPersistedState } from "./storage";
|
|
|
|
beforeEach(() => {
|
|
sessionStorage.setItem(ACTIVE_ACCOUNT_KEY, "1");
|
|
});
|
|
afterEach(() => {
|
|
sessionStorage.clear();
|
|
localStorage.clear();
|
|
});
|
|
|
|
describe("a page's sub-tab, per browser tab", () => {
|
|
it("starts on the fallback, then keeps the picked tab for this browser tab only", () => {
|
|
const first = renderHook(() => useTabPersistedState("siftlode.configTab", "access"));
|
|
expect(first.result.current[0]).toBe("access");
|
|
act(() => first.result.current[1]("plex"));
|
|
expect(sessionStorage.getItem("siftlode.configTab.1")).toBe("plex");
|
|
expect(localStorage.getItem("siftlode.configTab.1")).toBeNull();
|
|
// The page mounts again in this tab (a reload, or back from another page): it is where it was.
|
|
first.unmount();
|
|
expect(
|
|
renderHook(() => useTabPersistedState("siftlode.configTab", "access")).result.current[0],
|
|
).toBe("plex");
|
|
});
|
|
|
|
it("ignores a position left in localStorage by an older build, and clears it", () => {
|
|
localStorage.setItem("siftlode.configTab.1", "plex");
|
|
const { result } = renderHook(() => useTabPersistedState("siftlode.configTab", "access"));
|
|
expect(result.current[0]).toBe("access");
|
|
expect(localStorage.getItem("siftlode.configTab.1")).toBeNull();
|
|
});
|
|
|
|
it("a pre-selected tab is the one the page opens on", () => {
|
|
setTabRaw("siftlode.adminUsersTab", "access");
|
|
const { result } = renderHook(() => useTabPersistedState("siftlode.adminUsersTab", "roles"));
|
|
expect(result.current[0]).toBe("access");
|
|
});
|
|
});
|