Files
siftlode/frontend/src/components/plexPlayerControls.tsx
T
peter 4aaaaa7860 chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").

Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.

Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).

One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
2026-10-05 00:19:39 +02:00

135 lines
3.9 KiB
TypeScript

import { type ReactNode } from "react";
import { useTranslation } from "react-i18next";
import { RotateCcw } from "lucide-react";
import { IconButton } from "./ui/IconButton";
import { Slider as Range, CheckRow } from "./ui/NativeControls";
import { formatDecimal, formatUnit } from "../lib/format";
// --- settings-panel building blocks ------------------------------------------------------------
export function PanelHead({ children }: { children: ReactNode }) {
return (
<div className="px-1 pt-2 pb-1 text-2xs uppercase tracking-wide text-white/50">{children}</div>
);
}
export function Slider({
label,
value,
min,
max,
step,
suffix,
seconds,
onChange,
onReset,
}: {
label: string;
value: number;
min: number;
max: number;
step: number;
/** A symbol after the number ("%", "px"). */
suffix?: string;
/** The value is seconds: named in the UI language's unit ("0.5 sec" / "0,5 mp"). */
seconds?: boolean;
onChange: (v: number) => void;
onReset?: () => void;
}) {
const { t, i18n } = useTranslation();
const lang = i18n.language;
const shown = seconds
? formatUnit(value, "second", lang)
: `${formatDecimal(value, lang, 1, 0)}${suffix ?? ""}`;
return (
<div className="px-1 py-1">
<div className="mb-1 flex items-center justify-between text-[0.75rem] text-white/80">
<span>{label}</span>
<span className="flex items-center gap-1.5">
<span className="tabular-nums text-white/60">{shown}</span>
{onReset && (
<IconButton
variant="overlay"
onClick={onReset}
label={t("common.resetNamed", { name: label })}
className="-my-1.5"
>
<RotateCcw className="size-3.5!" />
</IconButton>
)}
</span>
</div>
<Range
min={min}
max={max}
step={step}
value={value}
aria-label={label}
onChange={(v) => onChange(v)}
/>
</div>
);
}
export function Toggle({
label,
checked,
onChange,
}: {
label: string;
checked: boolean;
onChange: (v: boolean) => void;
}) {
// The whole row toggles and grows to 44 on touch (CheckRow); the box sits at the row's end.
return (
<CheckRow
checked={checked}
onChange={onChange}
className="w-full flex-row-reverse justify-between px-1 py-1.5 text-[0.75rem] text-white/80"
>
{label}
</CheckRow>
);
}
// A control button with a tooltip that opens ABOVE it (so it never clips off the bottom of the
// viewport, unlike a native title tooltip on the bottom control bar).
export function Ctrl({
label,
onClick,
disabled,
align = "center",
children,
}: {
label: string;
onClick: () => void;
disabled?: boolean;
// Tooltip horizontal anchor: "start"/"end" for edge buttons so it doesn't clip off the viewport.
align?: "start" | "center" | "end";
children: ReactNode;
}) {
const pos =
align === "start" ? "left-0" : align === "end" ? "right-0" : "left-1/2 -translate-x-1/2";
// `will-change-[opacity]` keeps each tooltip on its own compositor layer from the start. Without it
// the browser promotes a tooltip only while its fade runs, and inside the player's scale(1.25)
// the neighbouring glyphs got re-layered with it: every button in the row shimmered as the
// pointer crossed one (seen by the owner).
return (
<div className="relative flex group/ctrl">
<IconButton
variant="overlay"
size="player"
round
noTitle
onClick={onClick}
disabled={disabled}
label={label}
>
{children}
</IconButton>
<span
className={`pointer-events-none absolute bottom-full ${pos} mb-2 whitespace-nowrap rounded-sm bg-black/90 px-2 py-1 text-2xs text-white opacity-0 will-change-[opacity] transition group-hover/ctrl:opacity-100`}
>
{label}
</span>
</div>
);
}