peter
471846d784
eslint now also enforces: - the React Compiler diagnostics that `recommended` leaves out (todo, memo-dependencies and ten zero-hit tripwires); - a description on every suppression, and no blanket disables; - no focused or skipped tests (vitest and playwright); - the typed pair no-floating-promises and no-deprecated. Lint also covers e2e/ and the TypeScript build configs, which `eslint .` had been skipping in silence. Every hit is fixed or suppressed inline with a named reason: - The 31 try statements the compiler cannot lower yet carry a suppression until S3 rewrites them. Five other compiler skips were plain fixes: a module counter bumped inside a hook, a ref read in a default parameter, and a local named like the <section> it renders. - The real defects behind floating promises are fixed. ChatDock threw at nobody when the device key store could not be opened. VideoEditor's play() rejection went unhandled. loadYouTubeApi never rejected, so a blocked IFrame API left the player on an empty stage forever; it now fails on a script error or after 15 s, shows its own error with the way out, and lets the next open try again. - MutableRefObject, FormEvent and lucide's deprecated brand icon are replaced. The YouTube glyph now lives in lib/brandIcons. - The lint-probe harness lets its virtual file names into TypeScript's default project, so the contract tests still run the real config.
92 lines
3.6 KiB
TypeScript
92 lines
3.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The channel page's video grid follows a running full-history backfill (bug hunt 2026-09, item 6).
|
|
// The rule itself — when a poll reading should refresh the grid — is pinned on the hook in
|
|
// lib/channelDetailPoll.backfill.dom.test.tsx. This pins that the PAGE runs it: deleting the hook's
|
|
// one call site left every lane green, knip included (the hook test's import kept the export "used").
|
|
//
|
|
// The page's own poll is what feeds the hook; a newer reading is handed to it here through the same
|
|
// query key the poll writes, rather than waiting out the 4 s interval. The Feed itself is stubbed —
|
|
// what matters is whether its queries are told they are stale.
|
|
import { describe, it, expect, vi, beforeAll, afterEach } from "vitest";
|
|
import { render, waitFor, cleanup, act } from "@testing-library/react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => ({
|
|
...(await importOriginal<typeof import("react-i18next")>()),
|
|
useTranslation: () => ({ t: (key: string) => key, i18n: { language: "en" } }),
|
|
}));
|
|
vi.mock("./navigationContext", () => ({
|
|
useNavigationActions: () => ({ closeChannel: vi.fn(), openChannel: vi.fn() }),
|
|
}));
|
|
vi.mock("./confirmContext", () => ({ useConfirm: () => async () => true }));
|
|
vi.mock("./feedFiltersContext", () => ({
|
|
useFeedFilters: () => ({ includeNormal: true, includeShorts: false, includeLive: false }),
|
|
}));
|
|
vi.mock("./Feed", () => ({ default: () => null }));
|
|
vi.mock("./ChannelAbout", () => ({ default: () => null }));
|
|
|
|
import ChannelPage from "./ChannelPage";
|
|
import { api, type ChannelDetail, type FeedFilters, type Me } from "../lib/api";
|
|
import { qk } from "../lib/queryKeys";
|
|
|
|
beforeAll(() => {
|
|
class Stub {
|
|
observe() {}
|
|
unobserve() {}
|
|
disconnect() {}
|
|
takeRecords() {
|
|
return [];
|
|
}
|
|
}
|
|
globalThis.ResizeObserver ??= Stub as unknown as typeof ResizeObserver;
|
|
globalThis.IntersectionObserver ??= Stub as unknown as typeof IntersectionObserver;
|
|
});
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
const CH = "UCsXVk37bltHxD1rDPwtNM8Q";
|
|
const reading = (stored_videos: number): ChannelDetail =>
|
|
({
|
|
id: CH,
|
|
title: "LEMMiNO",
|
|
subscribed: true,
|
|
deep_requested: true,
|
|
backfill_done: false,
|
|
stored_videos,
|
|
}) as unknown as ChannelDetail;
|
|
const feedKey = qk.feed({ q: "", channel: CH } as unknown as FeedFilters);
|
|
|
|
describe("ChannelPage — the grid follows a running backfill", () => {
|
|
it("marks the channel's video grid stale when the poll sees more stored videos", async () => {
|
|
vi.spyOn(api, "channelDetail").mockResolvedValue(reading(19));
|
|
vi.spyOn(api, "tags").mockResolvedValue([] as never);
|
|
const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
qc.setQueryData(feedKey, { pages: [{ items: [], next_cursor: null }], pageParams: [null] });
|
|
render(
|
|
<QueryClientProvider client={qc}>
|
|
<ChannelPage
|
|
channelId={CH}
|
|
initialName="LEMMiNO"
|
|
me={{ id: 1, can_write: true } as unknown as Me}
|
|
view="cards"
|
|
setView={() => {}}
|
|
onShowInFeed={() => {}}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
await waitFor(() => expect(api.channelDetail).toHaveBeenCalled());
|
|
await waitFor(() => expect(qc.getQueryData(qk.channel(CH))).toBeTruthy());
|
|
expect(qc.getQueryState(feedKey)?.isInvalidated).toBe(false);
|
|
|
|
// The next poll tick: the background job has stored 60 more.
|
|
act(() => {
|
|
qc.setQueryData(qk.channel(CH), reading(79));
|
|
});
|
|
|
|
await waitFor(() => expect(qc.getQueryState(feedKey)?.isInvalidated).toBe(true));
|
|
});
|
|
});
|