peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
84 lines
3.7 KiB
TypeScript
84 lines
3.7 KiB
TypeScript
import { test, expect } from "@playwright/test";
|
|
import { openApp } from "./helpers";
|
|
|
|
// Locks the feed's core contract: it renders cards, a filter re-queries it and surfaces a
|
|
// removable chip, and its virtualized list windows in fresh rows as you scroll.
|
|
test.describe("feed", () => {
|
|
test("a filter re-queries the feed and surfaces a removable chip", async ({ page }) => {
|
|
await openApp(page);
|
|
await expect(page.getByTestId("video-card").first()).toBeVisible();
|
|
|
|
const count = page.getByTestId("item-count");
|
|
await expect(count).toHaveText(/\d/);
|
|
const baseline = await count.innerText();
|
|
|
|
// Clean baseline: default filters, so no chips and "unwatched" is the active show (the Watch-state
|
|
// pill summarises the current pick).
|
|
await expect(page.getByTestId("active-filter-chip")).toHaveCount(0);
|
|
await expect(page.getByTestId("feed-show")).toContainText("Unwatched");
|
|
|
|
// Narrow to "watched" — open the Watch-state dropdown and pick it (single-select closes on pick).
|
|
// The seed guarantees exactly one, a real deterministic change.
|
|
await page.getByTestId("feed-show").click();
|
|
await page.getByTestId("feed-show-watched").click();
|
|
await expect(page.getByTestId("active-filter-chip")).toHaveCount(1);
|
|
await expect(count).not.toHaveText(baseline);
|
|
|
|
// Remove the chip → default show restored, chips gone.
|
|
await page.getByTestId("active-filter-chip").click();
|
|
await expect(page.getByTestId("active-filter-chip")).toHaveCount(0);
|
|
await expect(page.getByTestId("feed-show")).toContainText("Unwatched");
|
|
});
|
|
|
|
test("scrolling virtualizes in fresh cards", async ({ page }) => {
|
|
await openApp(page);
|
|
await expect(page.getByTestId("video-card").first()).toBeVisible();
|
|
|
|
const renderedIds = () =>
|
|
page
|
|
.getByTestId("video-card")
|
|
.evaluateAll((els) => els.map((e) => e.getAttribute("data-video-id")));
|
|
|
|
const before = await renderedIds();
|
|
expect(before.length).toBeGreaterThan(0);
|
|
|
|
// The feed scrolls inside <main> (role="main"), not the window.
|
|
await page.getByRole("main").evaluate((el) => el.scrollBy(0, 5000));
|
|
|
|
// A windowed list renders different rows once scrolled.
|
|
await expect
|
|
.poll(async () => (await renderedIds()).some((id) => id && !before.includes(id)))
|
|
.toBe(true);
|
|
});
|
|
|
|
// The toolbar (show/content chips, count, sort, view) is fixed chrome — it
|
|
// pins in the shell's toolbar band above the scroller, so it stays put while the cards scroll.
|
|
test("the feed toolbar stays pinned while cards scroll", async ({ page }) => {
|
|
await openApp(page);
|
|
const count = page.getByTestId("item-count");
|
|
await expect(count).toBeVisible();
|
|
const topBefore = await count.evaluate((el) => el.getBoundingClientRect().top);
|
|
|
|
await page.getByRole("main").evaluate((el) => el.scrollBy(0, 4000));
|
|
|
|
await expect(count).toBeInViewport();
|
|
const topAfter = await count.evaluate((el) => el.getBoundingClientRect().top);
|
|
expect(Math.abs(topAfter - topBefore)).toBeLessThan(4);
|
|
});
|
|
|
|
// Changing a filter is a fresh result set, so the scroll jumps back to the
|
|
// top rather than stranding you deep in the old list's offset.
|
|
test("a new filter resets the scroll to the top", async ({ page }) => {
|
|
await openApp(page);
|
|
await expect(page.getByTestId("video-card").first()).toBeVisible();
|
|
|
|
await page.getByRole("main").evaluate((el) => el.scrollBy(0, 4000));
|
|
expect(await page.getByRole("main").evaluate((el) => el.scrollTop)).toBeGreaterThan(500);
|
|
|
|
// Switch the show filter → a different result set → back to the top.
|
|
await page.getByTestId("feed-show").click();
|
|
await page.getByTestId("feed-show-all").click();
|
|
await expect.poll(() => page.getByRole("main").evaluate((el) => el.scrollTop)).toBeLessThan(50);
|
|
});
|
|
});
|