peter c4942eb590 fix(r5): address the fifth /code-review high round — 6 findings ...

- run_ffmpeg stops the process from ONE exit path (`except BaseException`), so
  an exception out of on_progress (a DB write) can no longer orphan a live
  ffmpeg after a 10s join on its pipes; _stop is now a no-op on a dead process
- both run_ffmpeg callbacks are throttled to ~1s (they were a DB round-trip per
  output line: ~10^5 queries on a long re-encode), mirroring the download hook
- volume arithmetic extracted to lib/playerVolume with unit tests; a corrupt
  level now falls back to the LAST GOOD one instead of full blast, and the
  sanitising happens where the stored value enters
- RSS is back to two except clauses (the shared tail already sits after the try)
- new tests: callback-exception cleanup, the two throttles; the fake Popen grew
  poll() and its wait count is now asserted

Mutation-checked: each new group goes red when its fix is reverted.

2026-07-24 01:50:50 +02:00

..

legal

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ui

refactor(z-index): name the stacking layers as a token scale

2026-07-18 19:11:25 +02:00

About.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

AboutCell.tsx

refactor(managers): full About overlay + center the wider channel content (E4 S2 follow-up)

2026-07-19 20:25:06 +02:00

ActiveFilterChips.tsx

test(e2e): golden-master Playwright net for the Platform refactor

2026-07-18 00:35:57 +02:00

AddToPlaylist.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

AdminUsers.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

auditColumns.tsx

refactor(format): hoist the relative-time tiers and lock their invariants

2026-07-20 22:17:51 +02:00

AuditLog.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

Avatar.tsx

fix(ui): robust avatars — no-referrer + graceful fallback

2026-06-12 18:01:43 +02:00

BackToTop.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Banner.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ChannelAbout.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

channelColumns.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ChannelDiscovery.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

ChannelLayoutGrid.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ChannelLink.tsx

refactor(channels): share one ChannelLink + channelYouTubeUrl helper

2026-06-19 03:22:10 +02:00

ChannelPage.tsx

fix(errors,a11y): review round 1 — drop redundant onErrors, stabilize the live region

2026-07-21 23:29:51 +02:00

ChannelPicker.tsx

feat(filters): filter the feed by several channels at once (OR)

2026-07-16 00:54:22 +02:00

Channels.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

ChannelsProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ChatDock.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ChatThread.tsx

fix(messages): re-review — degrade gracefully when partner has no key

2026-07-23 03:21:44 +02:00

ColumnSortControl.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ConfigPanel.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

ConfirmProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

DataTable.tsx

fix(ui): R3 S1 review fixes — don't blank data on transient refetch errors

2026-07-22 04:14:46 +02:00

DemoBanner.tsx

refactor(banner): extract reusable Banner base for VersionBanner + DemoBanner

2026-06-19 11:18:20 +02:00

DownloadButton.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

DownloadCenter.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

DownloadDialog.tsx

chore(ui): extract shared inputCls + btnCls to ui/form.tsx

2026-07-12 00:29:04 +02:00

ErrorBoundary.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ErrorDialog.tsx

fix(ux): modal error dialog for server-refused actions + ESC closes only the topmost

2026-06-18 01:17:31 +02:00

Feed.tsx

fix(r5): address the fourth /code-review high round — 6 findings

2026-07-24 00:45:42 +02:00

FeedFiltersProvider.tsx

docs(filters): correct the split-context comment

2026-07-18 18:30:18 +02:00

FeedViewProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

GlassTuner.tsx

refactor(frontend): satisfy noUncheckedIndexedAccess (S3b)

2026-07-21 04:11:19 +02:00

Header.tsx

refactor(channels): scope module state in ChannelsProvider

2026-07-19 00:08:34 +02:00

KeyGate.tsx

fix(messages): address S2 review — partner key refresh + reactive me

2026-07-23 03:11:35 +02:00

LanguageSwitcher.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Messages.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

Modal.tsx

i18n(a11y): translate the modal + Welcome close buttons and the feed fallback (C-3.22)

2026-07-21 23:13:53 +02:00

ModuleName.tsx

feat(header): floating module header with cyclic nav and shared search

2026-07-13 02:28:06 +02:00

moduleRegistry.tsx

feat(app): the module registry drives the render (S6b DoD)

2026-07-19 01:25:32 +02:00

NavigationProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

NavSidebar.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

NotificationsPanel.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

OnboardingWizard.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Overlay.tsx

refactor(overlay): single overlay-root convention via Overlay helper

2026-07-18 19:11:38 +02:00

Pager.tsx

fix(managers): address the E4 S3 code-review round 3 findings

2026-07-20 01:10:13 +02:00

PageScroller.tsx

fix(datatable): the sticky header no longer shifts or fades on first scroll

2026-07-18 05:43:19 +02:00

PageShell.tsx

fix(datatable): the sticky header no longer shifts or fades on first scroll

2026-07-18 05:43:19 +02:00

PanelGroup.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PanelGroups.tsx

fix(a11y): keyboard-reorder for panel groups (U-3.1.5)

2026-07-21 22:29:39 +02:00

PlayerModal.tsx

fix(r5): address the fifth /code-review high round — 6 findings

2026-07-24 01:50:50 +02:00

playlistColumns.tsx

fix(playlists): UAT round 1 — drag lag, an invisible default sort, dialog layout

2026-07-21 00:03:07 +02:00

Playlists.tsx

feat(ui): R3 S3 — surface swallowed errors

2026-07-22 04:43:02 +02:00

PlaylistsProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PlaylistsRail.tsx

feat(ui): R3 S2 — loading rows for blank-flash pages, error paths for forever-loading ones

2026-07-22 04:24:38 +02:00

PlexBrowse.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

PlexCollectionEditor.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PlexInfo.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PlexPlayer.tsx

fix(player): Escape coordination, focused-Space, light-theme menus (U-C, U-3.1.4, U-3.3.12)

2026-07-21 22:29:40 +02:00

PlexPlaylistAdd.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PlexPlaylistView.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

PlexProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PlexSidebar.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

PrefsProvider.tsx

refactor(prefs): move Settings auto-save machinery into PrefsProvider

2026-07-19 01:09:20 +02:00

ProfileEditor.tsx

fix(downloads): make shared files iOS-playable + default to 720p

2026-07-22 01:19:31 +02:00

QueryState.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

ReleaseNotes.tsx

fix(release-notes): ring the newest entry when the highlight version is unknown

2026-07-22 00:00:44 +02:00

SavedViewsWidget.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Scheduler.tsx

feat(ui): shared LoadingState — a centered accent spinner instead of plain loading text

2026-07-22 04:35:02 +02:00

SearchBar.tsx

feat(header): floating module header with cyclic nav and shared search

2026-07-13 02:28:06 +02:00

SettingsPanel.tsx

fix(errors,a11y): review round 1 — drop redundant onErrors, stabilize the live region

2026-07-21 23:29:51 +02:00

SetupWizard.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

ShareDialog.tsx

fix(downloads): confirm before clearing a link password; fix placeholder

2026-07-23 04:15:39 +02:00

Sidebar.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

SidePanel.tsx

refactor(z-index): name the stacking layers as a token scale

2026-07-18 19:11:25 +02:00

Stats.tsx

fix(ui): R3 review — give the Stats API-usage block its own loading/error state

2026-07-22 04:49:40 +02:00

SyncStatus.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

tableHeader.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Tabs.tsx

fix(state): scope all per-account localStorage by account id

2026-07-02 01:45:16 +02:00

TagManager.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Toaster.tsx

fix(a11y): don't force atomic re-announce of the whole toast stack

2026-07-21 23:36:27 +02:00

Tooltip.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

UndoToolbar.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

VersionBanner.tsx

refactor(banner): extract reusable Banner base for VersionBanner + DemoBanner

2026-06-19 11:18:20 +02:00

VideoCard.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

VideoEditor.tsx

refactor(frontend): satisfy noUncheckedIndexedAccess (S3b)

2026-07-21 04:11:19 +02:00

ViewSwitcher.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

VirtualFeed.tsx

refactor(feed): extract virtualization engine into a generic VirtualGrid<T>

2026-07-19 21:36:54 +02:00

VirtualGrid.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

WatchPage.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00

Welcome.tsx

fix(auth): address second-round review findings

2026-07-23 01:24:34 +02:00

WizardProvider.tsx

style(frontend): Prettier config + one-time repo-wide format pass

2026-07-21 02:26:40 +02:00