peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
40 lines
1.5 KiB
YAML
40 lines
1.5 KiB
YAML
# DB-backed pytest lane: an ephemeral Postgres + the test image, wired together so the
|
|
# `db` fixture (tests/conftest.py) has a real database. The whole thing is throwaway — the pg data
|
|
# lives in tmpfs (RAM) and nothing is persisted. The pure-logic lane still runs WITHOUT this file
|
|
# (plain `docker run … python -m pytest` — DB tests skip when no Postgres is reachable).
|
|
#
|
|
# docker compose -f backend/docker-compose.test.yml up --build --abort-on-container-exit \
|
|
# --exit-code-from test
|
|
# docker compose -f backend/docker-compose.test.yml down -v
|
|
services:
|
|
testdb:
|
|
image: postgres:16-alpine
|
|
environment:
|
|
POSTGRES_USER: siftlode
|
|
POSTGRES_PASSWORD: siftlode
|
|
POSTGRES_DB: siftlode_test
|
|
tmpfs:
|
|
- /var/lib/postgresql/data # ephemeral + fast; the schema is rebuilt per run
|
|
healthcheck:
|
|
test: ["CMD-SHELL", "pg_isready -U siftlode -d siftlode_test"]
|
|
interval: 1s
|
|
timeout: 3s
|
|
retries: 30
|
|
test:
|
|
build:
|
|
context: .
|
|
dockerfile: Dockerfile.test
|
|
depends_on:
|
|
testdb:
|
|
condition: service_healthy
|
|
environment:
|
|
DATABASE_URL: postgresql+psycopg://siftlode:siftlode@testdb:5432/siftlode_test
|
|
# This lane HAS a Postgres + ffmpeg, so the DB/ffmpeg tests must actually run here: conftest turns
|
|
# a would-be silent skip into a hard failure (SIFTLODE_TEST_REQUIRE_DB).
|
|
SIFTLODE_TEST_REQUIRE_DB: "1"
|
|
volumes:
|
|
- ./:/app
|
|
working_dir: /app
|
|
# Coverage is on demand, not in the gate: see docs/development.md.
|
|
command: ["python", "-m", "pytest"]
|